RFR: 8338763: GenShen: Global GC should not swap remembered sets for the verifier

[Kelvin Nilsen]

On Thu, 22 Aug 2024 19:00:26 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> It seems that subsequent improvements to remembered set verification have made this change unnecessary.
>> 
>> ## Testing
>> GHA, internal pipelines and local dacapo runs
>
> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 601:
> 
>> 599: 
>> 600:   if (heap->mode()->is_generational()) {
>> 601:     if (_generation->is_young()) {
> 
> My recollection is that ShenandoahVerify (at least one time) would verify the remembered set even for a global GC.  So that's why we needed to do this, to make the verifier happy.  Has this changed?

Your description of the PR says no longer necessary, so I guess that answers my question.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/485#discussion_r1727667378