RFR: 8338763: GenShen: Global GC should not swap remembered sets for the verifier

Y. Srinivas Ramakrishna ysr at openjdk.org
Thu Aug 22 20:57:42 UTC 2024


On Thu, 22 Aug 2024 19:01:11 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 601:
>> 
>>> 599: 
>>> 600:   if (heap->mode()->is_generational()) {
>>> 601:     if (_generation->is_young()) {
>> 
>> My recollection is that ShenandoahVerify (at least one time) would verify the remembered set even for a global GC.  So that's why we needed to do this, to make the verifier happy.  Has this changed?
>
> Your description of the PR says no longer necessary, so I guess that answers my question.

Can you check if there's a similar issue in `ShenandoahDegenGC::op_degenerated()` too?

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/485#discussion_r1727800196


More information about the shenandoah-dev mailing list