RFR: 8324649: Shenandoah: refactor implementation of free set [v6]

[Y. Srinivas Ramakrishna]

On Thu, 1 Feb 2024 06:06:06 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename and comments for _capacity_of and _used_by
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 44:
> 
>> 42: 
>> 43: // This class implements partitioning of regions into distinct sets.  Each ShenandoahHeapRegion is either in the Mutator free set,
>> 44: // the Collector free set, or in neither free set (NotFree).
> 
> I noticed that you use the term "free partition" quite a lot later, I'd just start using that term early on when talking about these sets. You could, for example, say:
> 
> // Whenever we say "free partition", we mean any partition other than the "NotFree" partition.

Or:

// Any partition that is not the "NotFree" partition is a "free partition".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1473912384