RFR: 8324649: Shenandoah: refactor implementation of free set [v6]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Feb 7 18:47:59 UTC 2024


On Thu, 1 Feb 2024 07:27:46 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 44:
>> 
>>> 42: 
>>> 43: // This class implements partitioning of regions into distinct sets.  Each ShenandoahHeapRegion is either in the Mutator free set,
>>> 44: // the Collector free set, or in neither free set (NotFree).
>> 
>> I noticed that you use the term "free partition" quite a lot later, I'd just start using that term early on when talking about these sets. You could, for example, say:
>> 
>> // Whenever we say "free partition", we mean any partition other than the "NotFree" partition.
>
> Or:
> 
> // Any partition that is not the "NotFree" partition is a "free partition".

Thanks.  I've made this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1481929525


More information about the shenandoah-dev mailing list