RFR: 8322630: Remove ICStubs and related safepoints [v6]

Dean Long dlong at openjdk.org
Fri Feb 9 01:34:00 UTC 2024


On Thu, 8 Feb 2024 21:44:14 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ARM32 fixes
>
> src/hotspot/cpu/x86/x86_64.ad line 1487:
> 
>> 1485: {
>> 1486:   MacroAssembler masm(&cbuf);
>> 1487:   masm.ic_check(CodeEntryAlignment);
> 
> I'm concerned about OptoBreakpoint and friends messing up the alignment:
> https://github.com/openjdk/jdk/blob/10beb3184e14e2714cd836029680a8b2d3fd5011/src/hotspot/share/opto/output.cpp#L317

It's fine, the breakpoint is insert *after* the prologue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1483776166


More information about the shenandoah-dev mailing list