RFR: 8322630: Remove ICStubs and related safepoints [v6]

Erik Österlund eosterlund at openjdk.org
Fri Feb 9 09:43:09 UTC 2024


On Fri, 9 Feb 2024 01:31:25 GMT, Dean Long <dlong at openjdk.org> wrote:

>> src/hotspot/cpu/x86/x86_64.ad line 1487:
>> 
>>> 1485: {
>>> 1486:   MacroAssembler masm(&cbuf);
>>> 1487:   masm.ic_check(CodeEntryAlignment);
>> 
>> I'm concerned about OptoBreakpoint and friends messing up the alignment:
>> https://github.com/openjdk/jdk/blob/10beb3184e14e2714cd836029680a8b2d3fd5011/src/hotspot/share/opto/output.cpp#L317
>
> It's fine, the breakpoint is insert *after* the prologue.

Yeah, that did have me confused as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484079876


More information about the shenandoah-dev mailing list