RFR: 8322630: Remove ICStubs and related safepoints [v6]

[Erik Österlund]

On Thu, 8 Feb 2024 11:52:51 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ARM32 fixes
>
> src/hotspot/share/oops/oopsHierarchy.hpp line 182:
> 
>> 180: class   Method;
>> 181: class   ConstantPool;
>> 182: //      class CHeapObj
> 
> Not sure why this is here, but maybe also remove this line.

Okay, removing.

> src/hotspot/share/runtime/sharedRuntime.cpp line 1369:
> 
>> 1367:   } else {
>> 1368:     // Callsite is a direct call - set it to the destination method
>> 1369:     CompiledICLocker ml(caller_nm);
> 
> Not sure if it makes sense to factor out the `CompiledICLocker ml(caller_nm); call in both if branches.

Sure, I can do that.

> src/hotspot/share/runtime/sharedRuntime.cpp line 1665:
> 
>> 1663: 
>> 1664:     // Check relocations for the matching call to 1) avoid false positives,
>> 1665:     // and 2) determine the type.
> 
> To me the comment is confusing (probably pre-existing): There does not seem to be a result of the code checking the relocations containing the "type" of the following code. I.e. the only reason this seems to be done here is reason 1), reason 2) seems obsolete.

Yeah I don't really understand what the comment is trying to say at all. I'll remove it.

> src/hotspot/share/runtime/sharedRuntime.cpp line 1807:
> 
>> 1805:   }
>> 1806: 
>> 1807:   assert(iter.has_current(), "must have a reloc at java call site");
> 
> This assert seems to be superfluous after the `if (!iter.next())` bailout just above.

Good point. Removing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484017440
PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484016694
PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484015431
PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484015615