RFR: 8322630: Remove ICStubs and related safepoints [v7]
Erik Österlund
eosterlund at openjdk.org
Fri Feb 9 08:43:22 UTC 2024
On Thu, 8 Feb 2024 11:09:30 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update src/hotspot/share/runtime/sharedRuntime.cpp
>>
>> Co-authored-by: Thomas Schatzl <59967451+tschatzl at users.noreply.github.com>
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 1837:
>
>> 1835: CompiledMethod* caller_nm = cb->as_compiled_method();
>> 1836:
>> 1837: for (;;) {
>
> I think the comment in line 1826 about
>
>
> // Transitioning IC caches may require transition stubs. If we run out
> // of transition stubs, we have to drop locks and perform a safepoint
> // that refills them.
>
> is out of date and should be removed. At least the code that generates the IC stubs below has been removed...
Good catch. I'll remove the comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484014998
More information about the shenandoah-dev
mailing list