RFR: 8322630: Remove ICStubs and related safepoints [v6]
Erik Österlund
eosterlund at openjdk.org
Fri Feb 9 09:05:21 UTC 2024
On Thu, 8 Feb 2024 12:27:26 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>>
>> ARM32 fixes
>
> src/hotspot/share/code/compiledMethod.cpp line 457:
>
>> 455: if (clean_all || !cm->is_in_use() || cm->is_unloading() || cm->method()->code() != cm) {
>> 456: cdc->set_to_clean();
>> 457: }
>
> Maybe a single `clean_if_nmethod_is_unloaded()` with the destination address as a parameter would avoid the code duplication with the other variant; otherwise another static helper function would be great.
Good point. I'll try on a template thing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484040893
More information about the shenandoah-dev
mailing list