RFR: 8322630: Remove ICStubs and related safepoints [v6]

[Erik Österlund]

On Thu, 8 Feb 2024 12:10:45 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ARM32 fixes
>
> src/hotspot/share/code/nmethod.cpp line 2310:
> 
>> 2308:       } else {
>> 2309:         CompiledDirectCall::at(call_site);
>> 2310:       }
> 
> Since `CompiledICLocker` does not lock anyway if it is safe (using the `is_safe` method), isn't the `if` superfluous here (and just keeping the `else` part does the same)?

That is true for DefaultICProtectionBehaviour::lock, but not ZGC and Shenandoah.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484022364