RFR: 8322630: Remove ICStubs and related safepoints [v6]

[Erik Österlund]

On Thu, 8 Feb 2024 09:16:36 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ARM32 fixes
>
> src/hotspot/share/opto/output.cpp line 3416:
> 
>> 3414:     } else {
>> 3415:       if (!target->is_static()) {
>> 3416:         _code_offsets.set_value(CodeOffsets::Entry, _first_block_size - MacroAssembler::ic_check_size());
> 
> This looks tricky. I think it means CodeOffsets::Entry starts after the alignment padding NOPs. If that's true then the `ic_check` functions could use a comment explaining that alignment needs to come first, not last. A comment here wouldn't hurt either.

Yes that's exactly it. I found that I got a less fortunate nop encoding that actually did show up as a tiny regression. It was fixed by not running the nops. I'll write a comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484046000