RFR: 8322630: Remove ICStubs and related safepoints [v6]

[Erik Österlund]

On Thu, 8 Feb 2024 09:18:20 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ARM32 fixes
>
> src/hotspot/cpu/aarch64/aarch64.ad line 2224:
> 
>> 2222:   // This is the unverified entry point.
>> 2223:   C2_MacroAssembler _masm(&cbuf);
>> 2224:   __ ic_check(CodeEntryAlignment);
> 
> I'm not sure we want to increase the alignement to CodeEntryAlignment here.  I believe C2 already aligns the root block to CodeEntryAlignment.  @theRealAph, what do you think?

I can change it to InteriorEntryAlignment which is what the VEP block is aligned to. I think it's still good that the root block is aligned to CodeEntryAlignment though. I heard some HW sheds some tears when their instruction cache lines also contain data that doesn't correspond to any actual instructions. But we can definitely align to InteriorEntryAlignment here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484096298