RFR: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi [v2]

[Roland Westrelin]

On Tue, 20 Feb 2024 11:49:27 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeLoadStoreMergedHeapStableTests.java
>>   
>>   Co-authored-by: Aleksey Shipilëv <shipilev at amazon.de>
>
> src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp line 1737:
> 
>> 1735: }
>> 1736: 
>> 1737: bool ShenandoahBarrierC2Support::merge_point_safe(Node* region) {
> 
> This should probably be `is_merge_point_safe`, since it answers `bool`?

There's an existing `merge_point_safe` method that validate merge points for split if (loopopts.cpp). That's why I named it like that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17926#discussion_r1495996962