RFR: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi [v2]

[Aleksey Shipilev]

On Tue, 20 Feb 2024 15:14:39 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp line 1737:
>> 
>>> 1735: }
>>> 1736: 
>>> 1737: bool ShenandoahBarrierC2Support::merge_point_safe(Node* region) {
>> 
>> This should probably be `is_merge_point_safe`, since it answers `bool`?
>
> There's an existing `merge_point_safe` method that validate merge points for split if (loopopts.cpp). That's why I named it like that.

Ah, okay then!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17926#discussion_r1496026273