RFR: 8336685: Shenandoah: Remove experimental incremental update mode [v2]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Fri Jul 26 01:09:40 UTC 2024
On Wed, 24 Jul 2024 19:31:04 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> We've reason to believe that this mode is very rarely used and its maintenance has become a burden for future development.
>>
>> ## Testing
>> * hotspot_gc_shenandoah
>> * dacapo
>> * diluvian
>> * extremem
>> * hyperalloc
>> * specjbb2015
>> * specjvm2008
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove unintentional new line
src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 122:
> 120:
> 121: ShenandoahMarkRefsClosure<GENERATION> mark_cl(q, rp);
> 122: ShenandoahSATBAndRemarkThreadsClosure tc(satb_mq_set, nullptr);
Because this is the only c'tor usage of this closure, may be get rid of the second argument altogether, and clean up its `do_thread()` method further above at lines 84-89 ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20316#discussion_r1690701759
More information about the shenandoah-dev
mailing list