RFR: 8336685: Shenandoah: Remove experimental incremental update mode [v2]
William Kemper
wkemper at openjdk.org
Fri Jul 26 15:32:38 UTC 2024
On Thu, 25 Jul 2024 02:24:43 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove unintentional new line
>
> src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 122:
>
>> 120:
>> 121: ShenandoahMarkRefsClosure<GENERATION> mark_cl(q, rp);
>> 122: ShenandoahSATBAndRemarkThreadsClosure tc(satb_mq_set, nullptr);
>
> Because this is the only c'tor usage of this closure, may be get rid of the second argument altogether, and clean up its `do_thread()` method further above at lines 84-89 ?
Right, @shipilev also pointed this out. I've since cleaned it up.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20316#discussion_r1693258254
More information about the shenandoah-dev
mailing list