RFR: 8325673: GenShen: Share Reserves between Old and Young Collector [v6]
Kelvin Nilsen
kdnilsen at openjdk.org
Fri Jul 26 19:25:29 UTC 2024
On Thu, 25 Jul 2024 00:54:46 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahOldHeuristics.hpp line 156:
>>
>>> 154: bool top_off_collection_set();
>>> 155:
>>> 156: // Return true iff the collection set holds at least one unpinned mixed evacuation candidate
>>
>> Same comment as the last one. The comment must not only state the value returned, but also what actions the method takes or side-effect it has on this or another interacting object's state. You want to do that for all imperative methods. (Only accessor methods may have a single line stating what they return; otherwise the effect of the method should be described.)
>
> (Applies to all the methods line 150-157.)
Here too. Done. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/395#discussion_r1693496020
More information about the shenandoah-dev
mailing list