RFR: 8325673: GenShen: Share Reserves between Old and Young Collector [v6]

Kelvin Nilsen kdnilsen at openjdk.org
Fri Jul 26 23:12:51 UTC 2024


On Thu, 25 Jul 2024 00:10:40 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 226:
>> 
>>> 224:     // on its next iteration and run a degenerated young cycle.
>>> 225: 
>>> 226:     // vmop_entry_final_updaterefs rebuilds free set in preparation for next GC.
>> 
>> Did you mean to say `vmop_entry_final_roots` in this comment?
>
> Also, are the comments at line 215 and 226 really needed, since the methods do much more than just rebuilding the free set.

I'll remove both of those comments.  You are right, I accidentally copy/pasted inappropriate comment in the second instance.  Thanks.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/395#discussion_r1693681705


More information about the shenandoah-dev mailing list