RFR: 8325673: GenShen: Share Reserves between Old and Young Collector [v6]

[Kelvin Nilsen]

On Thu, 25 Jul 2024 00:31:59 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 752:
>> 
>>> 750:     //  been set aside to hold objects evacuated from the young-gen collection set.  Conservatively, this value
>>> 751:     //  equals the entire amount of live young-gen memory within the collection set, even though some of this memory
>>> 752:     //  will likely be promoted.
>> 
>> It sounds like these comments should be moved (and split) into the `prepare_regions_and_collection_set()` header specification, and in its override for `ShenandoahOldGeneration`?
>
> The TODO comment at lines 727-734 should similarly move out into the method about which it talks.

Thanks.  I've moved these comments to more appropriate places.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/395#discussion_r1693693844