RFR: 8325673: GenShen: Share Reserves between Old and Young Collector [v6]

[Kelvin Nilsen]

On Thu, 25 Jul 2024 00:24:18 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 342:
>> 
>>> 340:   op_final_roots();
>>> 341: 
>>> 342:   if (heap->mode()->is_generational()) {
>> 
>> Can this code be factored out into a virtual method `rebuild_free_set()` that `ShenandoahGenerationalHeap` overrides?
>
> Also, can you take a look at `op_final_updaterefs` where `rebuild_free_set` is called? There may be an opportunity to refactor the code here into a method as suggested above, and to share that with `rebuild_free_set` perhaps.

Thanks for asking these questions.  The existing ShenandoahHeap::rebuild_free_set() method can be called from here instead of this code.  I'm making this change.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/395#discussion_r1693689110