RFR: 8333457: GenShen: Move remembered set into new generational code [v2]

[William Kemper]

On Mon, 3 Jun 2024 22:54:30 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo in comment
>
> src/hotspot/share/gc/shenandoah/shenandoahOldGeneration.cpp line 786:
> 
>> 784: }
>> 785: 
>> 786: void ShenandoahOldGeneration::mark_card_as_dirty(void* location) {
> 
> Do we need a paranoid assert here?
> 
> 
>  assert(is_in(location), ...);

This ultimately bottoms out in `CardTable::index_for`, which does assert that the location is in the heap: https://github.com/openjdk/shenandoah/blob/master/src/hotspot/share/gc/shared/cardTable.hpp#L160

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/443#discussion_r1626374415