RFR: 8333457: GenShen: Move remembered set into new generational code [v2]

[William Kemper]

On Mon, 3 Jun 2024 23:42:24 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo in comment
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 740:
> 
>> 738:   void clear_cards_for(ShenandoahHeapRegion* region);
>> 739:   void mark_card_as_dirty(void* location);
>> 740: 
> 
> Hurray!!

;)

> src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp line 32:
> 
>> 30: #include "gc/shared/spaceDecorator.hpp"
>> 31: #include "gc/shenandoah/shenandoahAffiliation.hpp"
>> 32: #include "gc/shenandoah/shenandoahAgeCensus.hpp"
> 
> This seemed very curious. Is it just for `CENSUS_NOISE()`? If so, I wonder if we should just pull it up into `shenandoah_globals.hpp` and avoid this seemingly curious include; or may be that's worse than the curious include? :-) 
> 
> Doesn't need to be done here necessarily, but the question might come up in a review when pushing this upstream in the future.

Yes, it's necessary for the definition of `CENSUS_NOISE`. I think it's fine to keep it in `shAgeCensus.hpp`. In my mind, `sh_globals.hpp` is really just for command line options.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/443#discussion_r1626393964
PR Review Comment: https://git.openjdk.org/shenandoah/pull/443#discussion_r1626393696