RFR: 8333750: GenShen: Only instantiate young/old generations in generational mode [v3]

William Kemper wkemper at openjdk.org
Tue Jun 11 18:58:28 UTC 2024


On Tue, 11 Jun 2024 17:58:51 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 734:
>> 
>>> 732:     } else {
>>> 733:       _heap->generation_for(r->affiliation())->increment_affiliated_region_count();
>>> 734:     }
>> 
>> Can the affiliation update be done unconditionally outside of the if-else, as when the affiliation is set at line 721, or if it needs to be done after the old region coalesce/fill/card-clearing, then after that at line 733, but unconditionally, skipping the update at line 731 for the old gen?
>
> Yes, that should be fine.

Yes, this should be fine.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/444#discussion_r1635346127


More information about the shenandoah-dev mailing list