RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

[Kelvin Nilsen]

On Mon, 17 Jun 2024 21:31:00 GMT, William Kemper <wkemper at openjdk.org> wrote:

> It looks like the comments for `ShenandoahFreeSet::internal_fragmentation` and `ShenandoahFreeSet::external_fragmentation` have been moved from the header into the implementation file when comparing against upstream (`jdk:master`). Can we keep them in-sync with upstream for the sake of minimizing differences here?

Agree.  I'm making this change.

> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 184:
> 
>> 182:   _rightmosts_empty[int(ShenandoahFreeSetPartitionId::Mutator)] = mutator_rightmost_empty;
>> 183: 
>> 184:   _region_counts[int(ShenandoahFreeSetPartitionId::Mutator)] = mutator_region_count;
> 
> This statement duplicates statement on line 178.

Thanks.  Removing.

> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 208:
> 
>> 206:   _rightmosts_empty[int(ShenandoahFreeSetPartitionId::OldCollector)] = old_collector_rightmost_empty;
>> 207: 
>> 208:   _region_counts[int(ShenandoahFreeSetPartitionId::OldCollector)] = old_collector_region_count;
> 
> Same duplication from `establish_mutator_intervals`.

Thanks here also.  Removing.

-------------

PR Comment: https://git.openjdk.org/shenandoah/pull/440#issuecomment-2176651406
PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1644850917
PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1644851614