RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

[Kelvin Nilsen]

On Mon, 17 Jun 2024 21:10:44 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor refinements to test programs
>>   
>>   TestAllocIntArrays: comments to explain behavior.
>>   TestOldGrowthTriggers: reduce the number of loop iterations so this test
>>   will not time out on less powerful test platforms.
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 344:
> 
>> 342:   // At start of update refs: Collector => Mutator
>> 343:   //                          OldCollector Empty => Mutator
>> 344:   assert (((available <= _region_size_bytes) &&
> 
> This is quite hard for my feeble brain to parse. Could we break this into multiple asserts? or break some of the expressions out into functions?

I agree that code is very difficult to understand.  I'm replacing with some function calls to make it more readable.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1644885021