RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Jun 18 20:15:25 UTC 2024


On Mon, 17 Jun 2024 21:18:03 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor refinements to test programs
>>   
>>   TestAllocIntArrays: comments to explain behavior.
>>   TestOldGrowthTriggers: reduce the number of loop iterations so this test
>>   will not time out on less powerful test platforms.
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 1226:
> 
>> 1224: }
>> 1225: 
>> 1226: void ShenandoahFreeSet::try_recycle_trashed(ShenandoahHeapRegion *r, bool is_generational) {
> 
> `is_generational` looks unused.

Thanks.  Removing this unneeded argument.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1645002286


More information about the shenandoah-dev mailing list