RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

[Kelvin Nilsen]

On Mon, 17 Jun 2024 21:12:39 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor refinements to test programs
>>   
>>   TestAllocIntArrays: comments to explain behavior.
>>   TestOldGrowthTriggers: reduce the number of loop iterations so this test
>>   will not time out on less powerful test platforms.
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 975:
> 
>> 973:     assert(!r->is_affiliated(), "New region " SIZE_FORMAT " should be unaffiliated", r->index());
>> 974:     r->set_affiliation(req.affiliation());
>> 975:     ShenandoahMarkingContext* const ctx = _heap->complete_marking_context();
> 
> Can we move this `ctx` closer to the `asserts` that use it, or perhaps inline the variable in the asserts?

Thanks.  Done.

> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 1178:
> 
>> 1176: 
>> 1177:   size_t remainder = words_size & ShenandoahHeapRegion::region_size_words_mask();
>> 1178:   ShenandoahMarkingContext* const ctx = _heap->complete_marking_context();
> 
> `ctx` looks unused.

Removed.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1644995791
PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1644995913