RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Jun 19 21:00:26 UTC 2024


On Tue, 18 Jun 2024 01:54:13 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor refinements to test programs
>>   
>>   TestAllocIntArrays: comments to explain behavior.
>>   TestOldGrowthTriggers: reduce the number of loop iterations so this test
>>   will not time out on less powerful test platforms.
>
> src/hotspot/share/gc/shenandoah/shenandoahGeneration.hpp line 155:
> 
>> 153:   size_t decrease_capacity(size_t decrement);
>> 154: 
>> 155:   size_t establish_capacity(size_t byte_size);
> 
> Why not simply `set_capacity` ? Also a 1-line comment.
> 
> // set the capacity of the generation, returning the value set.

Thanks.  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1646681507


More information about the shenandoah-dev mailing list