RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Jun 19 21:06:29 UTC 2024


On Tue, 18 Jun 2024 01:56:15 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor refinements to test programs
>>   
>>   TestAllocIntArrays: comments to explain behavior.
>>   TestOldGrowthTriggers: reduce the number of loop iterations so this test
>>   will not time out on less powerful test platforms.
>
> src/hotspot/share/gc/shenandoah/shenandoahGeneration.hpp line 150:
> 
>> 148:   void increase_allocated(size_t bytes);
>> 149: 
>> 150:   // These methods change the capacity of the region by adding or subtracting the given number of bytes from the current
> 
> I would say `generation`, instead of `region` here to avoid a little bit of unnecessary terminology confusion with the `heap region` object.
> 
> Also may be add something like: `Return the new capacity of the generation following the change.`

Agree.  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1646686817


More information about the shenandoah-dev mailing list