RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Jun 19 22:00:29 UTC 2024


On Tue, 18 Jun 2024 02:01:01 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor refinements to test programs
>>   
>>   TestAllocIntArrays: comments to explain behavior.
>>   TestOldGrowthTriggers: reduce the number of loop iterations so this test
>>   will not time out on less powerful test platforms.
>
> src/hotspot/share/gc/shenandoah/shenandoahGeneration.cpp line 757:
> 
>> 755:     heap->free_set()->prepare_to_rebuild(young_cset_regions, old_cset_regions, first_old, last_old, num_old);
>> 756:     // Free set construction uses reserve quantities, because they are known to be valid here
>> 757:     heap->free_set()->finish_rebuild(young_cset_regions, old_cset_regions, num_old, true);
> 
> is `num_old` different than the size of the `old_cset_regions` set?

I'll add a comment.  num_old is the number of regions that currently can be allocated from within the Collector set (excluding the old-gen cset).

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1646715262


More information about the shenandoah-dev mailing list