RFR: 8328235: GenShen: Robustify ShenandoahGCSession and fix missing use [v4]

Y. Srinivas Ramakrishna ysr at openjdk.org
Sat Jun 29 05:17:31 UTC 2024


On Thu, 23 May 2024 20:49:06 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Y. Srinivas Ramakrishna has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Small clean-ups.
>
> src/hotspot/share/gc/shenandoah/shenandoahGenerationalEvacuationTask.cpp line 134:
> 
>> 132:   {
>> 133:     const size_t old_garbage_threshold = (ShenandoahHeapRegion::region_size_bytes() * ShenandoahOldGarbageThreshold) / 100;
>> 134:     assert(_heap->gc_generation()->is_mark_complete(), "sanity");
> 
> Could use `_heap->gc_generation()->complete_marking_context()` on line 129, which just asserts that `is_mark_complete` before returning marking context.

Done.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/407#discussion_r1659594828


More information about the shenandoah-dev mailing list