RFR: 8328235: GenShen: Robustify ShenandoahGCSession and fix missing use [v4]

[Y. Srinivas Ramakrishna]

On Thu, 23 May 2024 20:54:49 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Y. Srinivas Ramakrishna has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Small clean-ups.
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp line 376:
> 
>> 374: 
>> 375:   assert(is_in(obj), "only check if is in active generation for objects (" PTR_FORMAT ") in heap", p2i(obj));
>> 376:   assert(gen == (ShenandoahGeneration*)old_generation() ||
> 
> These casts shouldn't be necessary any more.

Done... Seems more patently tautological now in the new form, but I'll let it stay in this form for now. Let me know if it can or should be removed entirely.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/407#discussion_r1659605122