RFR: 8330076: NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v13]

David Holmes dholmes at openjdk.org
Wed May 1 08:33:02 UTC 2024


On Tue, 23 Apr 2024 06:31:30 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed extra blank line.
>
> This is a big change, but the pattern of the changes is quite easy to follow.
> 
> I do have a couple of queries below.
> 
> Thanks

> @dholmes-ora, I am not sure if you got all your comments addressed. Would you please, have a look at here? Thanks.

My comments were addressed - thanks - but I will leave it to the experts in this area to grant the approvals. I did spot one change in testHelpers.cpp that had not actually been made yet.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18745#issuecomment-2088150756


More information about the shenandoah-dev mailing list