RFR: 8330076: NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v13]

[David Holmes]

On Tue, 23 Apr 2024 08:54:42 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> src/hotspot/share/memory/metaspace/testHelpers.cpp line 81:
>> 
>>> 79:   if (reserve_limit > 0) {
>>> 80:     // have reserve limit -> non-expandable context
>>> 81:     _rs = ReservedSpace(reserve_limit * BytesPerWord, Metaspace::reserve_alignment(), os::vm_page_size(), mtMetaspace);
>> 
>> I would make this mtTest. This should not increase the metaspace counters in NMT
>
> Done.

Huh! Now these comments are appearing saying it should be `mtTest` ??? I think github is messing things up here with hidden comments that make the actual time flow invisible.

@tstuefe  can you please clarify what this should be. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1586128894