RFR: 8330076: NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v13]

[Thomas Stuefe]

On Wed, 1 May 2024 08:30:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> This is a big change, but the pattern of the changes is quite easy to follow.
>> 
>> I do have a couple of queries below.
>> 
>> Thanks
>
>> @dholmes-ora, I am not sure if you got all your comments addressed. Would you please, have a look at here? Thanks.
> 
> My comments were addressed - thanks - but I will leave it to the experts in this area to grant the approvals. I did spot one change in testHelpers.cpp that had not actually been made yet.

Thanks @dholmes-ora for the eagle eye. Background: I prefer mtTest to mtWhatever in gtests, since it is what I expect to see in NMT (storage for test data = mtTest, "live" metaspace memory = mtMetaspate).

And god, is the GH interface terrible when patches get large. Its almost impossiible to keep an overview.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18745#issuecomment-2089813793