RFR: 8330076: NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v13]

Afshin Zafari azafari at openjdk.org
Thu May 2 07:23:07 UTC 2024


On Wed, 1 May 2024 08:30:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> This is a big change, but the pattern of the changes is quite easy to follow.
>> 
>> I do have a couple of queries below.
>> 
>> Thanks
>
>> @dholmes-ora, I am not sure if you got all your comments addressed. Would you please, have a look at here? Thanks.
> 
> My comments were addressed - thanks - but I will leave it to the experts in this area to grant the approvals. I did spot one change in testHelpers.cpp that had not actually been made yet.

Thank you @dholmes-ora for your review with a sharp eye that found that missed change.
Thank you @tstuefe, @stefank, @shipilev  and @jdksjolen for your comments and reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18745#issuecomment-2089780895


More information about the shenandoah-dev mailing list