RFR: 8324649: Shenandoah: replace implementation of free set [v57]

Kelvin Nilsen kdnilsen at openjdk.org
Fri May 10 17:57:22 UTC 2024


On Fri, 10 May 2024 14:53:13 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Another attempt at improving clarity of comments
>
> src/hotspot/share/gc/shenandoah/shenandoahSimpleBitMap.cpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2016, 2021, Red Hat, Inc. All rights reserved.
> 
> The copyright seems wrong. This is entirely new code by you, right? Should only have Amazon copyright notice, then.

Thanks for review.  I'll work through these suggestions.  Question about copyright: I guess this is pretty much "all new", but the code was derived from original code, and much of the public API was borrowed from original.  So I think maybe I should keep Red Hat copyright, and add Amazon copyright.  What do you advise?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1597050924


More information about the shenandoah-dev mailing list