RFR: 8332095: GenShen: Move more generational mode members out of shHeap

Kelvin Nilsen kdnilsen at openjdk.org
Mon May 13 16:44:22 UTC 2024


On Fri, 10 May 2024 23:02:51 GMT, William Kemper <wkemper at openjdk.org> wrote:

> The following members and methods in shHeap are only used in generational mode and can be moved out of common code:
> * ShenandoahHeap::cancel_old_gc
> * ShenandoahHeap::transfer_old_pointers_from_satb
> * ShenandoahHeap::_is_aging_cycle

Thanks.

src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 1218:

> 1216:   }
> 1217: 
> 1218:   // This needs to see is_aging_cycle

This comment is a bit unclear.  Are we saying we need the heap state to capture whether this is an aging cycle, because that will influence which regions get aged at the end of update refs?

-------------

Marked as reviewed by kdnilsen (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/431#pullrequestreview-2053181879
PR Review Comment: https://git.openjdk.org/shenandoah/pull/431#discussion_r1598749704


More information about the shenandoah-dev mailing list