RFR: 8332095: GenShen: Move more generational mode members out of shHeap

[William Kemper]

On Mon, 13 May 2024 16:30:15 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> The following members and methods in shHeap are only used in generational mode and can be moved out of common code:
>> * ShenandoahHeap::cancel_old_gc
>> * ShenandoahHeap::transfer_old_pointers_from_satb
>> * ShenandoahHeap::_is_aging_cycle
>
> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 1218:
> 
>> 1216:   }
>> 1217: 
>> 1218:   // This needs to see is_aging_cycle
> 
> This comment is a bit unclear.  Are we saying we need the heap state to capture whether this is an aging cycle, because that will influence which regions get aged at the end of update refs?

No, that was more of a 'note to self' to make sure the method calls didn't get re-ordered as part of this refactoring. I'll update the comment.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/431#discussion_r1598896480