RFR: 8328235: GenShen: Robustify ShenandoahGCSession and fix missing use [v4]

[Y. Srinivas Ramakrishna]

On Thu, 23 May 2024 20:52:02 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Y. Srinivas Ramakrishna has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Small clean-ups.
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 1578:
> 
>> 1576: void ShenandoahHeap::set_gc_generation(ShenandoahGeneration* generation) {
>> 1577:   _gc_generation = generation;
>> 1578:   assert(Thread::current() == ShenandoahController::thread() ||
> 
> Could use `shenandoah_assert_control_or_vm_thread` from `shenandoahAsserts.hpp` here?

Done (defined and used a stronger version of the assertion that checks that we are at a safepoint if vm thread).

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/407#discussion_r1617292646