RFR: 8328235: GenShen: Robustify ShenandoahGCSession and fix missing use [v4]

[Y. Srinivas Ramakrishna]

On Thu, 23 May 2024 20:59:19 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Y. Srinivas Ramakrishna has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Small clean-ups.
>
> src/hotspot/share/gc/shenandoah/shenandoahController.cpp line 31:
> 
>> 29: #include "gc/shenandoah/shenandoahHeapRegion.inline.hpp"
>> 30: 
>> 31: Thread* ShenandoahController::_thread = nullptr;
> 
> I don't think this is necessary. We already have `ShenandoahHeap::control_thread()`, which is the same thing. That is `ShenandoahControlThread::this == Thread::current() == ShenandoahHeap::_control_thread`.

Thanks, removed & replaced usage.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/407#discussion_r1617337449