RFR: 8331539: [REDO] NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v2]

[Stefan Karlsson]

On Mon, 27 May 2024 21:25:12 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> My point is that the `archive_space_rs` and `class_space_rs` can get the wrong flags assigned to them. The split functions don't change them. Right?
>> 
>> I would like to see the code run through our testing with these checks:
>> 
>>   assert(archive_space_rs.nmt_flag() == mtClassShared, "Sanity");
>>   assert(class_space_rs.nmt_flag() == mtClass, "Sanity");
>
> The call to `MemTracker::record_virtual_memory_split_reserved` at line 1364, takes two flags for the split parts. The corresponding regions in NMT take that flags.
> The sanity assertions will be added anyway.

I think you are still missing my point. `record_virtual_memory_split_reserved` doesn't update the `archive_space_rs` and `class_space_rs` instances with the correct flag.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19343#discussion_r1618362958