RFR: 8331539: [REDO] NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v2]

Afshin Zafari azafari at openjdk.org
Wed May 29 10:52:01 UTC 2024


On Wed, 29 May 2024 07:39:24 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The call to `MemTracker::record_virtual_memory_split_reserved` at line 1364, takes two flags for the split parts. The corresponding regions in NMT take that flags.
>> The sanity assertions will be added anyway.
>
> I think you are still missing my point. `record_virtual_memory_split_reserved` doesn't update the `archive_space_rs` and `class_space_rs` instances with the correct flag.

Oh yes sorry. I was referring to the regions and flags in NMT. 
Since this PR is going to be closed without merge, no need to do any change in the code. But I remember it for future.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19343#discussion_r1618672203


More information about the shenandoah-dev mailing list