RFR: 8344797: GenShen: Update and rename confusing method

[Y. Srinivas Ramakrishna]

On Thu, 21 Nov 2024 21:49:35 GMT, William Kemper <wkemper at openjdk.org> wrote:

> A few riders here:
> * [Remove vestigial debugging assertions](https://github.com/openjdk/shenandoah/commit/9062113458bd1909409967abb743e11982f351ab)
> * [Log cancellation time at debug level](https://github.com/openjdk/shenandoah/commit/e3dd23efcb179bc61565d25f6b46f3690a50caa4)
> * [Use try_set instead of set](https://github.com/openjdk/shenandoah/pull/550/commits/49cb66a0fa7d0d660f5b986eea9d71035c157310)

LGTM (including riders :-)

src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.cpp line 61:

> 59:         return true;
> 60:       }
> 61:       start_idx++;

Thanks for fixing this and emphasizing that the test is ever only done within a single region.

-------------

Marked as reviewed by ysr (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/550#pullrequestreview-2453042394
PR Review Comment: https://git.openjdk.org/shenandoah/pull/550#discussion_r1853106837