RFR: 8344797: GenShen: Update and rename confusing method

[Kelvin Nilsen]

On Thu, 21 Nov 2024 21:49:35 GMT, William Kemper <wkemper at openjdk.org> wrote:

> A few riders here:
> * [Remove vestigial debugging assertions](https://github.com/openjdk/shenandoah/commit/9062113458bd1909409967abb743e11982f351ab)
> * [Log cancellation time at debug level](https://github.com/openjdk/shenandoah/commit/e3dd23efcb179bc61565d25f6b46f3690a50caa4)
> * [Use try_set instead of set](https://github.com/openjdk/shenandoah/pull/550/commits/49cb66a0fa7d0d660f5b986eea9d71035c157310)

Marked as reviewed by kdnilsen (Committer).

src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 881:

> 879:   // update costs on slow path.
> 880:   monitoring_support()->notify_heap_changed();
> 881:   _heap_changed.try_set();

I'm not sure I understand the significance of this change from .set() to .try_set().

src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp line 274:

> 272:   if (_cancel_requested_time > 0) {
> 273:     double cancel_time = os::elapsedTime() - _cancel_requested_time;
> 274:     log_debug(gc)("GC cancellation took %.3fs", cancel_time);

may not be significant, but would prefer to avoid os::elapsedTime() invocation if we're not logging debug.

-------------

PR Review: https://git.openjdk.org/shenandoah/pull/550#pullrequestreview-2453043393
PR Review Comment: https://git.openjdk.org/shenandoah/pull/550#discussion_r1853124695
PR Review Comment: https://git.openjdk.org/shenandoah/pull/550#discussion_r1853107542