RFR: 8344779: GenShen: Consolidate shared heap region closures into one header

Y. Srinivas Ramakrishna ysr at openjdk.org
Fri Nov 22 00:42:34 UTC 2024


On Thu, 21 Nov 2024 19:25:27 GMT, William Kemper <wkemper at openjdk.org> wrote:

> Move shared heap region closure implementations into one header, move non-shared implementations closer to their only usage.

LGTM

src/hotspot/share/gc/shenandoah/shenandoahMarkClosures.cpp line 2:

> 1: /*
> 2:  * Copyright (c) 2021, Red Hat, Inc. All rights reserved.

This had me confused, but I verified that the deletion of the Copyright line is indeed correct based on what I can tell from `git annotate`.

Also the way the rename shows up in the diffs here is pretty subtle.

-------------

Marked as reviewed by ysr (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/549#pullrequestreview-2453066219
PR Review Comment: https://git.openjdk.org/shenandoah/pull/549#discussion_r1853122849


More information about the shenandoah-dev mailing list