RFR: 8344779: GenShen: Consolidate shared heap region closures into one header

William Kemper wkemper at openjdk.org
Fri Nov 22 17:35:35 UTC 2024


On Fri, 22 Nov 2024 00:38:15 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Move shared heap region closure implementations into one header, move non-shared implementations closer to their only usage.
>
> src/hotspot/share/gc/shenandoah/shenandoahMarkClosures.cpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2021, Red Hat, Inc. All rights reserved.
> 
> This had me confused, but I verified that the deletion of the Copyright line is indeed correct based on what I can tell from `git annotate`.
> 
> Also the way the rename shows up in the diffs here is pretty subtle.

Yes, git has a mind of its own when it comes to renames.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/549#discussion_r1854356528


More information about the shenandoah-dev mailing list