RFR: 8342001: GenShen: Factor cases for allocation type into separate methods [v2]

[William Kemper]

On Mon, 14 Oct 2024 20:36:41 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve comments for new methods
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 813:
> 
>> 811:            "Boundaries or find_last_set_bit failed: " SSIZE_FORMAT, idx);
>> 812:     ShenandoahHeapRegion* r = _heap->get_region(idx);
>> 813:     // try_allocate_in() increases used if the allocation is successful.
> 
> I think the comment about what `try_allocate_in()` does belongs as a spec comment for that method, rather than here. I assume `used` in this comment refers to the used bytes for the (here, mutator) partition?

Moved the comment and expanded it some.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/511#discussion_r1800186238