RFR: 8342001: GenShen: Factor cases for allocation type into separate methods [v2]

[William Kemper]

On Mon, 14 Oct 2024 21:21:33 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve comments for new methods
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 899:
> 
>> 897: }
>> 898: 
>> 899: HeapWord* ShenandoahFreeSet::try_allocate_from_mutator(ShenandoahAllocRequest& req, bool& in_new_region) {
> 
> Why does this always use right-biased allocation from the mutator partition? (And not update allocation bias state?) Is this intentional? I assume it's because these aren't fresh allocations, but evacuations. Do evacuations with right bias end up closer to allocations for other evacuations? A brief comment explaining this difference from mutator allocation would be useful.

I think it makes sense that the collector would take regions from the mutator according to the allocation bias for the _collector_. @kdnilsen , what do you think?

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/511#discussion_r1800188425