RFR: 8339346: GenShen: Remove even more stale TODOs
William Kemper
wkemper at openjdk.org
Wed Sep 4 00:02:38 UTC 2024
On Tue, 3 Sep 2024 23:15:53 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.hpp line 785:
>>
>>> 783: void mark_range_as_dirty(size_t card_index, size_t num_cards);
>>> 784: void mark_card_as_clean(size_t card_index);
>>> 785: void mark_range_as_clean(size_t card_index, size_t num_cards);
>>
>> Are these being removed because the "card_index" arg versions are never used, only the "heapword*" arg versions?
>
> Can the "TODO:" at line 748 (old line 761) also be removed, or is there a good reason to keep it for now?
Yes, these aren't used. I'm removing that TODO in the next batch after I remove the last of the unused methods.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/491#discussion_r1742825809
More information about the shenandoah-dev
mailing list